Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.10] [fix] [broker] Fix isolated group not work problem. #21098

Conversation

horizonzy
Copy link
Member

@horizonzy horizonzy commented Aug 30, 2023

Motivation

This is a cherry-pick commit for #21096.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@horizonzy horizonzy changed the title Fix isolated group not work problem. [branch-2.10] [fix] [broker] Fix isolated group not work problem. Aug 30, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Aug 30, 2023
Copy link
Contributor

@hangc0276 hangc0276 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to protect the logic

@hangc0276 hangc0276 added type/bug The PR fixed a bug or issue reported a bug ready-to-test labels Aug 30, 2023
@hangc0276 hangc0276 added this to the 3.2.0 milestone Aug 30, 2023
@hangc0276
Copy link
Contributor

/pulsarbot run-failure-checks

@horizonzy
Copy link
Member Author

/pulsarbot run-failure-checks

1 similar comment
@horizonzy
Copy link
Member Author

/pulsarbot run-failure-checks

@mattisonchao
Copy link
Member

mattisonchao commented Sep 5, 2023

Please wait for this PR to fix some tests.

@horizonzy
Copy link
Member Author

/pulsarbot run-failure-checks

@mattisonchao
Copy link
Member

Hi, @horizonzy

You should rebase your branch to branch-2.10

@horizonzy horizonzy force-pushed the branch-2.10-fix-isolated-group-not-work branch from 28a7150 to cc8f08a Compare September 6, 2023 02:33
@codelipenghui codelipenghui merged commit 0026719 into apache:branch-2.10 Sep 6, 2023
26 of 27 checks passed
@Technoboy- Technoboy- removed this from the 3.2.0 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.10 doc-not-needed Your PR changes do not impact docs ready-to-test release/2.10.6 type/bug The PR fixed a bug or issue reported a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants