Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][doc] Add more configuration methods for basic authentication #16941

Merged
merged 1 commit into from Aug 7, 2022

Conversation

nodece
Copy link
Member

@nodece nodece commented Aug 4, 2022

Signed-off-by: Zixuan Liu nodeces@gmail.com

Motivation

Add documentation for #16935, #16526 and #15822.

image

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@nodece
Copy link
Member Author

nodece commented Aug 4, 2022

@momo-jun Could you help review this PR?

Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding docs for #16935 and #16526. I left one comment.

@github-actions
Copy link

github-actions bot commented Aug 5, 2022

@nodece Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@nodece
Copy link
Member Author

nodece commented Aug 5, 2022

@momo-jun Your request has been fixed. Could you help review it again?

Copy link
Contributor

@momo-jun momo-jun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Can you also remove the indention in line110~114?

@github-actions github-actions bot added doc-label-missing doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. and removed doc-label-missing labels Aug 5, 2022
@apache apache deleted a comment from github-actions bot Aug 5, 2022
@apache apache deleted a comment from github-actions bot Aug 5, 2022
Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Copy link
Contributor

@Jason918 Jason918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jason918 Jason918 merged commit 70cca00 into apache:master Aug 7, 2022
Jason918 pushed a commit that referenced this pull request Aug 7, 2022
#16941)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit 70cca00)
@Jason918 Jason918 added the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Aug 7, 2022
@codelipenghui
Copy link
Contributor

We don't need to cherry-pick doc PRs, the docs are only maintained on the master branch with multiple dirs. Instead, we should change all the versioned-doc. @nodece @Jason918

@nodece
Copy link
Member Author

nodece commented Aug 8, 2022

@codelipenghui Thanks for telling me that!

Technoboy- pushed a commit that referenced this pull request Aug 8, 2022
momo-jun added a commit to momo-jun/pulsar that referenced this pull request Aug 9, 2022
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
@momo-jun momo-jun added this to the 2.11.0 milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants