Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][authentication] Adapt basic authentication configuration with prefix #16935

Merged
merged 1 commit into from Aug 4, 2022

Conversation

nodece
Copy link
Member

@nodece nodece commented Aug 3, 2022

Signed-off-by: Zixuan Liu nodeces@gmail.com

Motivation

Fix #16526 (comment), which supports the following config:

basicAuthConf=data:;base64,YOUR-BASE64
basicAuthConf=file:///my/basic.conf
basicAuthConf=YOUR-BASE64
basicAuthConf=/my/basic.conf

Documentation

Check the box below or label this PR directly.

Need to update docs?

…th prefix

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Copy link
Contributor

@Technoboy- Technoboy- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodece nodece merged commit cd95594 into apache:master Aug 4, 2022
@mattisonchao
Copy link
Member

Hi, @nodece
Could you help to cherry-pick this PR for branch-2.9?

nodece added a commit to nodece/pulsar that referenced this pull request Aug 4, 2022
…th prefix (apache#16935)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit cd95594)
@nodece
Copy link
Member Author

nodece commented Aug 4, 2022

Move release/2.9.4 to #16944.

@nodece
Copy link
Member Author

nodece commented Aug 4, 2022

Move release/2.7.5 to #16947.

@nodece nodece added this to the 2.11.0 milestone Aug 5, 2022
@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels Aug 5, 2022
BewareMyPower pushed a commit that referenced this pull request Aug 5, 2022
…th prefix (#16935)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit cd95594)
@BewareMyPower BewareMyPower added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Aug 5, 2022
codelipenghui pushed a commit that referenced this pull request Aug 8, 2022
…th prefix (#16935)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit cd95594)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Aug 16, 2022
…th prefix (apache#16935)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
(cherry picked from commit cd95594)
(cherry picked from commit 0a4add6)
Technoboy- pushed a commit to merlimat/pulsar that referenced this pull request Aug 16, 2022
…th prefix (apache#16935)

Signed-off-by: Zixuan Liu <nodeces@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-picked/branch-2.8 Archived: 2.8 is end of life cherry-picked/branch-2.10 doc-complete Your PR changes impact docs and the related docs have been already added. release/2.8.4 release/2.10.2 release/2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants