New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transaction] Fix transaction system topic create in loop #12889
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -67,6 +67,9 @@ public TopicName load(String name) throws Exception { | |
public static final TopicName TRANSACTION_COORDINATOR_ASSIGN = TopicName.get(TopicDomain.persistent.value(), | ||
NamespaceName.SYSTEM_NAMESPACE, "transaction_coordinator_assign"); | ||
|
||
public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(), | ||
NamespaceName.SYSTEM_NAMESPACE, "__transaction_log_"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are you sure about this '_transaction_log' ? it is strange that it ends with an underscore character There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it ends with an underscore character, because there is a coordinator id behind the |
||
|
||
public static TopicName get(String domain, NamespaceName namespaceName, String topic) { | ||
String name = domain + "://" + namespaceName.toString() + '/' + topic; | ||
return TopicName.get(name); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NotAllowedException
is related to security problems (authorisation).why are we rewriting this to "CONFLICT" ? shouldn't it be "FORBIDDEN" ?