[Transaction] Fix transaction system topic create in loop #12889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
congbobo184
requested review from
gaoran10,
eolivelli,
codelipenghui and
merlimat
eolivelli
requested changes
Nov 19, 2021
| @@ -67,6 +67,9 @@ public TopicName load(String name) throws Exception { | |||
| public static final TopicName TRANSACTION_COORDINATOR_ASSIGN = TopicName.get(TopicDomain.persistent.value(), | |||
| NamespaceName.SYSTEM_NAMESPACE, "transaction_coordinator_assign"); | |||
|
|
|||
| public static final TopicName TRANSACTION_COORDINATOR_LOG = TopicName.get(TopicDomain.persistent.value(), | |||
| NamespaceName.SYSTEM_NAMESPACE, "__transaction_log_"); | |||
There was a problem hiding this comment.
are you sure about this '_transaction_log' ? it is strange that it ends with an underscore character
There was a problem hiding this comment.
it ends with an underscore character, because there is a coordinator id behind the __transaction_log_.
…ansaction_system_topic_create_in_loop
eolivelli
reviewed
Nov 22, 2021
| @@ -3517,7 +3526,10 @@ private Topic getTopicReference(TopicName topicName) { | |||
| } catch (RestException e) { | |||
| throw e; | |||
| } catch (Exception e) { | |||
| throw new RestException(e); | |||
| if (e.getCause() instanceof NotAllowedException) { | |||
There was a problem hiding this comment.
NotAllowedException is related to security problems (authorisation).
why are we rewriting this to "CONFLICT" ? shouldn't it be "FORBIDDEN" ?
eolivelli
approved these changes
Nov 22, 2021
codelipenghui
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
link #12749