remove pulsar-standalone image #11657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codelipenghui
approved these changes
Aug 13, 2021
sijie
approved these changes
Aug 13, 2021
1 task
1 task
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
### Motivation Currently, the pulsar-dashboard has been removed in apache#11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image. in apache#11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master. I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes. ### Modifications - remove pulsar-standalone image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, the pulsar-dashboard has been removed in #11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image.
in #11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master.
I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes.
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
If yes, please update docs or create a follow-up issue if you need help.
If no, please explain why.
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doclabel.if you plan to update docs later, label this PR with the
doc-requiredlabel.if you need help on updating docs, create a follow-up issue with the
doc-requiredlabel.If no, label this PR with the
no-need-doclabel and explain why.