Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unnecessary user interactions when building pulsar-standalone image #11623

Merged
merged 1 commit into from Aug 10, 2021

Conversation

timmyyuan
Copy link
Contributor

@timmyyuan timmyyuan commented Aug 10, 2021

Avoiding user interaction with tzdata installation when building pulsar-standalone image (https://askubuntu.com/questions/909277/avoiding-user-interaction-with-tzdata-when-installing-certbot-in-a-docker-contai)

Fix #11620

@timmyyuan timmyyuan changed the title Fix unnecessary user interactions in building pulsar-standalone image Fix unnecessary user interactions when building pulsar-standalone image Aug 10, 2021
@codelipenghui codelipenghui self-assigned this Aug 10, 2021
@codelipenghui codelipenghui added this to the 2.9.0 milestone Aug 10, 2021
@merlimat
Copy link
Contributor

We should just get rid of the pulsar-standalone Docker image. The only point of this was to include the web dashboard which was already deprecated and removed from master.

@eolivelli
Copy link
Contributor

We should just get rid of the pulsar-standalone Docker image. The only point of this was to include the web dashboard which was already deprecated and removed from master.

I was going to send a patch before my vacations but I forgot.
I will be happy to do it now

@eolivelli eolivelli merged commit 18ecf3c into apache:master Aug 10, 2021
@codelipenghui codelipenghui deleted the ting/fix-user-interaction branch August 11, 2021 03:56
@freeznet
Copy link
Contributor

@eolivelli may I know the progress of your work? if it is not started yet, I am happy to work on that and you may review it later.

@freeznet freeznet mentioned this pull request Aug 13, 2021
1 task
@freeznet
Copy link
Contributor

@eolivelli I just created a PR #11657 to remove the pulsar-standalone image, PTAL when you have time, thanks.

sijie pushed a commit that referenced this pull request Aug 13, 2021
### Motivation

Currently, the pulsar-dashboard has been removed in #11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image.

in #11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master. 

I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes.

### Modifications

- remove pulsar-standalone image
timmyyuan pushed a commit to streamnative/pulsar-archived that referenced this pull request Aug 26, 2021
hangc0276 pushed a commit that referenced this pull request Aug 27, 2021
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Aug 27, 2021
gaoran10 added a commit to gaoran10/pulsar that referenced this pull request Sep 10, 2021
2. Build python client by Python3.8

cherry-pick:
1. apache#11026
2. apache#11623
3. apache#11862
codelipenghui pushed a commit that referenced this pull request Sep 14, 2021
### Motivation

Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`.

Mainly related PRs:

1. #11026
2. #11623
3. #11862

### Modifications

Build docker image from the `ubuntu:20.04`.

upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever #9124 from branch-2.7
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
### Motivation

Currently, the pulsar-dashboard has been removed in apache#11284, as the pulsar-standalone image is required pulsar-dashboard and provide dashboard service in one container, which leads to building failure in pulsar-standalone image.

in apache#11623, as @merlimat suggests, this PR removes the pulsar-standalone image from master. 

I did a quick search in the codebase to find if there is any doc related to pulsar-standalone image but seems no doc related to pulsar-standalone image anymore. so this PR will not include any doc changes.

### Modifications

- remove pulsar-standalone image
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jul 22, 2022
Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`.

Mainly related PRs:

1. apache#11026
2. apache#11623
3. apache#11862

Build docker image from the `ubuntu:20.04`.

upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever apache#9124 from branch-2.7

(cherry picked from commit 259c698)
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Jul 22, 2022
Currently, the docker is from `openjdk:8-jdk-slim `, it has a new release a few days ago and the Linux version was changed to `Impish`, it didn't support install `python3.7` by apt-get tool, the minimum Python version is 3.9, so we need to change the python version or use a different Linux release, I cherry-pick some commits from branch master to build docker image from the `ubuntu:20.04`.

Mainly related PRs:

1. apache#11026
2. apache#11623
3. apache#11862

Build docker image from the `ubuntu:20.04`.

upgrade pulsar-go-client from `0.2.0` to `0.6.0` and rever apache#9124 from branch-2.7

(cherry picked from commit 259c698)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Build] Building the pulsar-standalone image requires user interaction
6 participants