Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[broker] Improve error logs in BacklogQuotaManager #11469

Merged
merged 1 commit into from Aug 2, 2021
Merged

[broker] Improve error logs in BacklogQuotaManager #11469

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 5 additions & 5 deletions pulsar-broker/src/main/java/org/apache/pulsar/broker/service/BacklogQuotaManager.java
View file
Open in desktop
Expand Up @@ -191,13 +191,13 @@ private void dropBacklogForSizeLimit(PersistentTopic persistentTopic, BacklogQuo
}
// Skip messages on the slowest consumer
if (log.isDebugEnabled()) {
log.debug("Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]",
messagesToSkip, slowestConsumer.getName(), entriesInBacklog);
log.debug("[{}] Skipping [{}] messages on slowest consumer [{}] having backlog entries : [{}]",
persistentTopic.getName(), messagesToSkip, slowestConsumer.getName(), entriesInBacklog);
}
slowestConsumer.skipEntries(messagesToSkip, IndividualDeletedEntries.Include);
} catch (Exception e) {
log.error("Error skipping [{}] messages from slowest consumer : [{}]", messagesToSkip,
slowestConsumer.getName());
log.error("[{}] Error skipping [{}] messages from slowest consumer [{}]", persistentTopic.getName(),
messagesToSkip, slowestConsumer.getName(), e);
}

// Make sure that unconsumed size is updated every time when we skip the messages.
Expand Down Expand Up @@ -250,7 +250,7 @@ private void dropBacklogForTimeLimit(PersistentTopic persistentTopic, BacklogQuo
ledgerInfo = mLedger.getLedgerInfo(ledgerId).get();
}
} catch (Exception e) {
log.error("Error resetting cursor for slowest consumer [{}]: {}",
log.error("[{}] Error resetting cursor for slowest consumer [{}]", persistentTopic.getName(),
mLedger.getSlowestConsumer().getName(), e);
}
}
Expand Down