Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broker] Improve error logs in BacklogQuotaManager #11469

Merged
merged 1 commit into from Aug 2, 2021

Conversation

massakam
Copy link
Contributor

Motivation

The following error was detected on one of our brokers.

Error skipping [310] messages from slowest consumer : [shared5]

However, this message does not tell we which topic caused the problem. Also, the stack trace of the exception is not output. Therefore, it is difficult to investigate the cause.

Modifications

Output the topic name and the stack trace of the exception along with the above error message.

Verifying this change

  • Make sure that the change passes the CI checks.

@massakam massakam added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker doc-not-needed Your PR changes do not impact docs labels Jul 28, 2021
@massakam massakam added this to the 2.9.0 milestone Jul 28, 2021
@massakam massakam self-assigned this Jul 28, 2021
@codelipenghui codelipenghui merged commit 084eebf into apache:master Aug 2, 2021
@massakam massakam deleted the improve-error-log branch August 3, 2021 04:38
codelipenghui pushed a commit that referenced this pull request Aug 4, 2021
@codelipenghui codelipenghui added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Aug 4, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker cherry-picked/branch-2.8 Archived: 2.8 is end of life doc-not-needed Your PR changes do not impact docs release/2.8.1 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants