Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Broker] Fix replicated subscriptions direct memory leak #11396

Merged
merged 1 commit into from Jul 22, 2021
Merged

[Broker] Fix replicated subscriptions direct memory leak #11396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions ...n/java/org/apache/pulsar/broker/service/persistent/ReplicatedSubscriptionsController.java
View file
Open in desktop
Expand Up @@ -123,7 +123,7 @@ public void localSubscriptionUpdated(String subscriptionName, ReplicatedSubscrip
}

ByteBuf subscriptionUpdate = Markers.newReplicatedSubscriptionsUpdate(subscriptionName, clusterIds);
topic.publishMessage(subscriptionUpdate, this);
writeMarker(subscriptionUpdate);
}

private void receivedSnapshotRequest(ReplicatedSubscriptionsSnapshotRequest request) {
Expand All @@ -140,8 +140,7 @@ private void receivedSnapshotRequest(ReplicatedSubscriptionsSnapshotRequest requ
request.getSourceCluster(),
localCluster,
lastMsgId.getLedgerId(), lastMsgId.getEntryId());

topic.publishMessage(marker, this);
writeMarker(marker);
}

private void receivedSnapshotResponse(Position position, ReplicatedSubscriptionsSnapshotResponse response) {
Expand Down Expand Up @@ -276,7 +275,11 @@ void snapshotCompleted(String snapshotId) {
}

void writeMarker(ByteBuf marker) {
topic.publishMessage(marker, this);
try {
topic.publishMessage(marker, this);
} finally {
marker.release();
}
}

/**
Expand Down