[Broker] Fix replicated subscriptions direct memory leak #11396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
type/bug
rdhabalia
approved these changes
Jul 20, 2021
merlimat
approved these changes
Jul 21, 2021
codelipenghui
approved these changes
Jul 21, 2021
lhotari
added a commit
that referenced
this pull request
Jul 22, 2021
- .release() wasn't called for marker messages sent by ReplicatedSubscriptionsController. - Use writeMarker method to publish marker messages and call release in try-finally block. (cherry picked from commit 8841c81)
lhotari
added a commit
that referenced
this pull request
Jul 22, 2021
- .release() wasn't called for marker messages sent by ReplicatedSubscriptionsController. - Use writeMarker method to publish marker messages and call release in try-finally block. (cherry picked from commit 8841c81)
Technoboy-
pushed a commit
to Technoboy-/pulsar
that referenced
this pull request
Jul 22, 2021
- .release() wasn't called for marker messages sent by ReplicatedSubscriptionsController. - Use writeMarker method to publish marker messages and call release in try-finally block.
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
- .release() wasn't called for marker messages sent by ReplicatedSubscriptionsController. - Use writeMarker method to publish marker messages and call release in try-finally block.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11383
Motivation
Using replicated subscriptions results in a direct memory leak. See #11383 for more details.
Modifications
.release()wasn't called for marker messages sent by ReplicatedSubscriptionsController. UsewriteMarkermethod to publish marker messages and call release in try-finally block.