Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIFI-13183] add drop shadow to connections to increase visibility on… #8778

Merged
merged 2 commits into from
May 9, 2024
Merged

[NIFI-13183] add drop shadow to connections to increase visibility on… #8778

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b719064
[NIFI-13183] add drop shadow to connections to increase visibility on…
scottyaslan May 8, 2024
ed6adb5
review feedback
scottyaslan May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 8 additions & 5 deletions ...frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,9 @@
$nifi-theme-caution-palette-darker: mat.get-color-from-palette($nifi-theme-caution-palette, darker);

// Shadows should always be darker. We explicitly set this so the SVG shadows are correct in both modes.
$drop-shadow-color: black;
$is-dark: map-get($nifi-theme-color-config, is-dark);
$drop-shadow-color: black;
$connection-drop-shadow-color: if($is-dark, black, white);

$nifi-theme-surface-palette-darker-contrast: mat.get-color-from-palette(
$nifi-theme-surface-palette,
Expand Down Expand Up @@ -209,10 +210,6 @@
flood-color: $drop-shadow-color;
}

#connection-full-drop-shadow feFlood {
flood-color: $material-theme-warn-palette-darker;
}

rect.processor-read-write-stats {
fill: if($is-dark, $nifi-theme-surface-palette-darker, $nifi-theme-surface-palette-lighter);
}
Expand Down Expand Up @@ -261,6 +258,9 @@
/*
Connection
*/
#connection-full-drop-shadow feFlood {
flood-color: $material-theme-warn-palette-darker;
}

g.connection {
font-family: mat.get-theme-typography($material-theme, body-1, font-family);
Expand Down Expand Up @@ -297,6 +297,9 @@
g.connection path.connection-path {
fill: none;
stroke: $surface-contrast;
filter: drop-shadow(
0 3px 6px if($is-dark, $nifi-theme-surface-palette-darker, $nifi-theme-surface-palette-lighter)
);
}

g.connection path.connection-path.full {
Expand Down