Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NIFI-13183] add drop shadow to connections to increase visibility on… #8778

Merged
merged 2 commits into from May 9, 2024
Merged

[NIFI-13183] add drop shadow to connections to increase visibility on… #8778

merged 2 commits into from May 9, 2024

Conversation

scottyaslan
Copy link
Contributor

… top of colored labels in both light and dark mode

@scottyaslan scottyaslan added the new ui Pull requests for work relating to the new user interface being developed. label May 8, 2024
@scottyaslan scottyaslan requested a review from rfellows May 8, 2024 18:05
@scottyaslan scottyaslan force-pushed the NIFI-13183 branch 2 times, most recently from 03f527f to 7155b9b Compare May 8, 2024 19:00
@scottyaslan
[NIFI-13183] add drop shadow to connections to increase visibility on…
b719064 
… top of colored labels in both light and dark mode
rfellows
rfellows requested changes May 8, 2024
View reviewed changes
Copy link
Contributor

@rfellows rfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can tell what is causing this issue, but if the connection line is vertical (or nearly vertical) the arrows disappear and the line get narrower and the drop shadow goes away.

Screenshot 2024-05-08 at 3 21 30 PM Screenshot 2024-05-08 at 3 21 39 PM

@scottyaslan scottyaslan requested a review from rfellows May 8, 2024 22:16
@scottyaslan
Copy link
Contributor Author

scottyaslan commented May 8, 2024 •
edited

@rfellows thanks for the thorough review! Great catch. I found this STO that I think hints at the issue you are seeing. Applying the drop shadow via css seems to have fixed it.

rfellows
rfellows approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@rfellows rfellows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are a good improvement over the old UI and look great in both light and dark modes 👍

@rfellows rfellows merged commit a61bf2a into apache:main May 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfellows rfellows rfellows approved these changes

Assignees
No one assigned
Labels
new ui Pull requests for work relating to the new user interface being developed.
Projects
None yet
Milestone
No milestone
2 participants
@scottyaslan @rfellows