Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatLaf from 2.4 to 2.5 #4803

Merged
merged 3 commits into from Oct 18, 2022

Conversation

neilcsmith-net
Copy link
Member

Replacement for #4696 fixing the merge conflict (I didn't want to force push directly to the PR).

DevCharly and others added 3 commits October 17, 2022 12:40
…rsion

This allows modules that need access to the internal packages and
accept, that they will be version locked to declare an implementation
dependency on this module.
@neilcsmith-net neilcsmith-net added this to the NB16 milestone Oct 17, 2022
@mbien mbien added Upgrade Library Library (Dependency) Upgrade UI User Interface labels Oct 17, 2022
Copy link
Member

@mbien mbien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good + it works on my system which is even better.

What are the native libs for again? Will this break NB if someone starts it on ARM or are those only for optional flatlaf features?

@DevCharly
Copy link
Member

What are the native libs for again?

They are used for FlatLaf window decorations and embedded menu bar.

Will this break NB if someone starts it on ARM or are those only for optional flatlaf features?

No, FlatLaf checks the CPU architecture. ARM is not (yet) supported by FlatLaf. So it will not try to load any native library and use default behavior (Windows 10/11 window decorations; menu bar not embedded)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User Interface Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants