Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FlatLaf from 2.5 to 2.6 #4811

Merged
merged 1 commit into from Oct 19, 2022
Merged

Update FlatLaf from 2.5 to 2.6 #4811

merged 1 commit into from Oct 19, 2022

Conversation

DevCharly
Copy link
Member

Update FlatLaf to v2.6.

This version now uses System.loadLibrary() to load native libs (as suggested here),
always loads libjawt (as suggested here)
and fixes some minor issues.

Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/2.6

@DevCharly DevCharly added Upgrade Library Library (Dependency) Upgrade UI User Interface labels Oct 18, 2022
@DevCharly DevCharly added this to the NB16 milestone Oct 18, 2022
@neilcsmith-net
Copy link
Member

Thanks @DevCharly Only minor niggle would be that this now should allow the native libraries to go in arch/OS specific paths like the others. @matthiasblaesing ??

@mbien mbien added the ci:all-tests [ci] enable all tests label Oct 18, 2022
@apache apache locked and limited conversation to collaborators Oct 18, 2022
@apache apache unlocked this conversation Oct 18, 2022
@mbien
Copy link
Member

mbien commented Oct 18, 2022

restarted CI with all tests active

@mbien
Copy link
Member

mbien commented Oct 18, 2022

#4803 broke platform/core.startup tests (restarted twice):
https://github.com/apache/netbeans/actions/runs/3272323634
exit code 1. So probably JVM crash - haven't investigated further.

This is fixing it. We should get this in ;)

Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me. Verified on OpenJDK 17 on amd64 that the native library is loaded via the NetBeans mechanism (single stepped through org.netbeans.StandardModule.OneModuleClassLoader.findLibrary(String))

@mbien mbien merged commit c926afc into apache:master Oct 19, 2022
@neilcsmith-net
Copy link
Member

@mbien wasn't a JVM crash. The CachingPreventsFileTouchesTest was failing, either due to use of InstalledFileLocator in validate() or my suggestion to use the parent directory directly as the argument.

Possibly a sign we should be running platform tests more often?

@mbien
Copy link
Member

mbien commented Oct 19, 2022

@neilcsmith-net agreed, I had the same thought. I could make UI trigger platform tests since it doesn't do anything right now. Or we should just use Platform more often?

but in general: if we upgrade a library which is used everywhere, we should add ci:all-tests. I missed that one too, I thought commit validation would catch a problem like this one.

@DevCharly DevCharly deleted the flatlaf-2.6 branch December 3, 2022 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:all-tests [ci] enable all tests UI User Interface Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants