New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update FlatLaf from 2.5 to 2.6 #4811
Conversation
Thanks @DevCharly Only minor niggle would be that this now should allow the native libraries to go in arch/OS specific paths like the others. @matthiasblaesing ?? |
restarted CI with all tests active |
#4803 broke This is fixing it. We should get this in ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me. Verified on OpenJDK 17 on amd64 that the native library is loaded via the NetBeans mechanism (single stepped through org.netbeans.StandardModule.OneModuleClassLoader.findLibrary(String)
)
@mbien wasn't a JVM crash. The Possibly a sign we should be running platform tests more often? |
@neilcsmith-net agreed, I had the same thought. I could make but in general: if we upgrade a library which is used everywhere, we should add |
Update FlatLaf to v2.6.
This version now uses
System.loadLibrary()
to load native libs (as suggested here),always loads
libjawt
(as suggested here)and fixes some minor issues.
Changes: https://github.com/JFormDesigner/FlatLaf/releases/tag/2.6