Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure RAT plugin ignores files in the target folder #813

Merged
merged 4 commits into from Oct 5, 2022
Merged

Make sure RAT plugin ignores files in the target folder #813

merged 4 commits into from Oct 5, 2022

Conversation

gnodet
Copy link
Contributor

@gnodet gnodet commented Oct 5, 2022 •
edited

When switching branches, left-over target folder often causes issues with the rat-maven-plugin.
Ignoring those folders does help from a day-to-day pov.

See #814 and #815

@gnodet gnodet requested a review from cstamas October 5, 2022 10:00
@gnodet
Fix gitignore so that it can work with rat, do not inherit execution …
ecb52cd 
…in children, use a single place to configure rat
@gnodet
Copy link
Contributor Author

gnodet commented Oct 5, 2022

@michael-o @cstamas I gave it another try
The rat plugin does read the .gitignore file to add excludes, but the syntax is slightly different in that it does not assume ** before and after the pattern, so I fixed the target/ into **/target/** so that it works for both.
If you add a repo/ and use that directory as the local repo, it should be ignore too.
I've also disabled the execution in child modules.

@gnodet gnodet merged commit 37b579b into apache:master Oct 5, 2022
gnodet added a commit to gnodet/maven that referenced this pull request Oct 5, 2022
@gnodet
Make sure RAT plugin ignores files in the target folder (apache#813)
5c6327e 
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit to gnodet/maven that referenced this pull request Oct 5, 2022
@gnodet
Make sure RAT plugin ignores files in the target folder (apache#813)
7f9bde4 
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit that referenced this pull request Oct 5, 2022
@gnodet
Make sure RAT plugin ignores files in the target folder (#813) (#814)
3b79723 
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
gnodet added a commit that referenced this pull request Oct 5, 2022
@gnodet
Make sure RAT plugin ignores files in the target folder (#813) (#815)
a7a5b81 
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
@gnodet gnodet deleted the rat-target-master branch October 5, 2022 14:57
@gnodet gnodet mentioned this pull request May 16, 2023
Merged
@gnodet gnodet mentioned this pull request May 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cstamas cstamas cstamas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gnodet @cstamas