Skip to content

Commit

Permalink
Make sure RAT plugin ignores files in the target folder (#813)
Browse files Browse the repository at this point in the history
* Make sure RAT plugin ignores files in the target folder
* Fix gitignore so that it can work with rat, do not inherit execution in children, use a single place to configure rat
* Exclude .asf.yaml from rat check
* Add repo/ to the .gitignore file as it's often used for local repository
  • Loading branch information
gnodet committed Oct 5, 2022
1 parent 2a9f393 commit 37b579b
Show file tree
Hide file tree
Showing 3 changed files with 35 additions and 30 deletions.
3 changes: 2 additions & 1 deletion .gitignore
@@ -1,4 +1,4 @@
target/
**/target/**
.project
.classpath
.settings/
Expand All @@ -14,3 +14,4 @@ target/
.checkstyle
.factorypath
.vscode/
repo/
10 changes: 10 additions & 0 deletions maven-bom/pom.xml
Expand Up @@ -160,6 +160,16 @@ under the License.
<topSiteURL>${project.distributionManagement.site.url}/..</topSiteURL>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<executions>
<execution>
<id>rat-check</id>
<phase>none</phase>
</execution>
</executions>
</plugin>
</plugins>
</build>
</project>
52 changes: 23 additions & 29 deletions pom.xml
Expand Up @@ -573,27 +573,6 @@ under the License.
<artifactId>buildnumber-maven-plugin</artifactId>
<version>1.4</version>
</plugin>
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes>
<exclude>**/.gitattributes</exclude>
<exclude>src/test/resources*/**</exclude>
<exclude>src/test/projects/**</exclude>
<exclude>src/test/remote-repo/**</exclude>
<exclude>**/*.odg</exclude>
<!--
! Excluded the license files itself cause they do not have have a license of themselves.
-->
<exclude>src/main/appended-resources/licenses/MIT-slf4j-api-1.7.30.txt</exclude>
<exclude>src/main/appended-resources/licenses/EPL-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-aopalliance-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-javax.annotation-api-1.3.2.txt</exclude>
<exclude>plexus-utils/target/**</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</pluginManagement>
<plugins>
Expand Down Expand Up @@ -635,14 +614,29 @@ under the License.
<plugin>
<groupId>org.apache.rat</groupId>
<artifactId>apache-rat-plugin</artifactId>
<configuration>
<excludes combine.children="append">
<exclude>bootstrap/**</exclude>
<exclude>README.bootstrap.txt</exclude>
<exclude>README.md</exclude>
<exclude>**/.factorypath</exclude>
</excludes>
</configuration>
<executions>
<execution>
<id>rat-check</id>
<inherited>false</inherited>
<configuration>
<excludes>
<exclude>**/.gitattributes</exclude>
<exclude>src/test/resources*/**</exclude>
<exclude>src/test/projects/**</exclude>
<exclude>src/test/remote-repo/**</exclude>
<exclude>**/*.odg</exclude>
<exclude>.asf.yaml</exclude>
<!--
! Excluded the license files itself cause they do not have have a license of themselves.
-->
<exclude>src/main/appended-resources/licenses/MIT-slf4j-api-1.7.30.txt</exclude>
<exclude>src/main/appended-resources/licenses/EPL-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-aopalliance-1.0.txt</exclude>
<exclude>src/main/appended-resources/licenses/unrecognized-javax.annotation-api-1.3.2.txt</exclude>
</excludes>
</configuration>
</execution>
</executions>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
Expand Down

0 comments on commit 37b579b

Please sign in to comment.