[MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of maven-compat #280
Conversation
cstamas
changed the title
...gin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java
Outdated
Show resolved
Hide resolved
cstamas
changed the title
...gin/src/main/java/org/apache/maven/plugin/plugin/metadata/AddPluginArtifactMetadataMojo.java
Show resolved
Hide resolved
| // nothing if Maven is 3.9+ | ||
| try { | ||
| if (versionScheme | ||
| .parseVersion("3.9.0") | ||
| .compareTo(versionScheme.parseVersion(runtimeInformation.getMavenVersion())) | ||
| < 1) { | ||
| getLog().info("This Mojo is not used in Maven version 3.9.0 and above"); | ||
| return; | ||
| } | ||
| } catch (InvalidVersionSpecificationException e) { | ||
| // not happening with generic | ||
| throw new MojoExecutionException(e); | ||
| } | ||
|
|
||
| projectArtifact.addMetadata(groupMetadata); | ||
| LegacySupport.execute(project, getGoalPrefix()); |
There was a problem hiding this comment.
We should be careful with it .... probably it is used by Nexus Staging Plugin
https://issues.apache.org/jira/browse/MPLUGIN-384
There was a problem hiding this comment.
I consider nexus-staging-maven-plugin legacy, simply put, people should avoid using it... all the benefits it (may) add, is that you don't have to log into Nx UI and press "close" button. Simply put, not worth if you contrast that to legacy burden it brings and have.
There was a problem hiding this comment.
I fully agree with @cstamas and ignore it.
There was a problem hiding this comment.
We will see how many people use nexus-staging
There was a problem hiding this comment.
Is it materialized .... https://issues.apache.org/jira/browse/MNG-8121 ❓
There was a problem hiding this comment.
This change is unrelated. What happened is that those users had no prefix set (ever), so remote metadata has no prefix either, and now that they upgraded, and forced to set plugin prefix (in latest m-p-p), NPE happens.
|
This will constitute a great 3.13.0 release. |
Update parent POM to 42, up prerequisite to 3.6.3. As parent 42 removes implicit (sisu) indexing, added explicitly indexing to all modules, as I think they all need it (may be wrong here).
The Mojo
AddPluginArtifactMetadataMojopulls in classes that have transitive (classes) coming from maven-compat. In fact, this mojo is not required at all since Maven 3.9.0 as resolver handles all transparently.https://issues.apache.org/jira/browse/MPLUGIN-519
https://issues.apache.org/jira/browse/MPLUGIN-520