[MNG-7266] Remove maven-compat

[Giovds]

Following this checklist to help us incorporate your
contribution quickly and easily:

• Make sure there is a JIRA issue filed
  for the change (usually before you start working on it). Trivial changes like typos do not
  require a JIRA issue. Your pull request should address just this issue, without
  pulling in other changes.
• Each commit in the pull request should have a meaningful subject line and body.
• Format the pull request title like [MNG-XXX] SUMMARY,
  where you replace MNG-XXX and SUMMARY with the appropriate JIRA issue.
• Also format the first line of the commit message like [MNG-XXX] SUMMARY.
  Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message.
• Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
• Run mvn clean verify to make sure basic checks pass. A more thorough check will
  be performed on your pull request automatically.
• You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

• I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

• In any other case, please file an Apache Individual Contributor License Agreement.

[cstamas]

maven-site plugin is still maven2 dependant...

[cstamas]

@michael-o can we have a taste on new Ms from site suite?

[Giovds]

I've noticed in the .svg that the compat module sits between core and wagon-provider-api. What is the next step for the wagon-provider-api?

Does this mean we remove the wagon-provider-api as well, or do we link core with wagon-provider-api, or is there another path we should take?

[cstamas]

I think wagon-provider-api is a must as it is used in Maven3 plugins as well... so only compat is the one that is getting booted

[michael-o]

@michael-o can we have a taste on new Ms from site suite?

You want to me run the entire test setup of Doxia/MSITE w/o depending on maven-compat or with with PR of Maven 4?

[cstamas]

@michael-o if you look at failed CI jobs, they are due msite plugin wanting stuff that is actually removed (maven-compat). Am interested could you -- maybe even within this PR -- set up M versions that hopefully does not depends on maven-compat?

[michael-o]

@michael-o if you look at failed CI jobs, they are due msite plugin wanting stuff that is actually removed (maven-compat). Am interested could you -- maybe even within this PR -- set up M versions that hopefully does not depends on maven-compat?

Ok, I see what you are after. Will look into this.

[michael-o]

@cstamas I gave it a spin. A few components rely falsely on maven-compat, this can be removed, but the larger work is on doxia-sitetools which still use classes from maven-compat. I'd like to complete this release trail and then have a look with you at doxia-sitetools how to remove those classes and then the entire stack can be made free of maven-compat.

[cstamas]

For start, maven-compat is really just test dep, not needed at runtime
apache/maven-doxia-sitetools#151

[michael-o]

Someone needs to fix maven-plugin-plugin first:

[INFO]
[INFO] --- jar:3.3.0:jar (default-jar) @ maven-site-plugin ---
[INFO] Building jar: /var/osipovmi/Projekte/maven-site-plugin/target/maven-site-plugin-4.0.0-M14-SNAPSHOT.jar
[INFO]
[INFO] --- plugin:3.10.2:addPluginArtifactMetadata (default-addPluginArtifactMetadata) @ maven-site-plugin ---
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] --------------------------------------------------------------------------------------------------------------------------
[INFO] Total time:  02:07 min
[INFO] Finished at: 2024-04-28T12:34:23+02:00
[INFO] --------------------------------------------------------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata (default-addPluginArtifactMetadata) on project maven-site-plugin: Execution default-addPluginArtifactMetadata of goal org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata failed: A required class was missing while executing org.apache.maven.plugins:maven-plugin-plugin:3.10.2:addPluginArtifactMetadata: org/apache/maven/artifact/repository/metadata/ArtifactRepositoryMetadata
[ERROR] -----------------------------------------------------
[ERROR] realm =    plugin>org.apache.maven.plugins:maven-plugin-plugin:3.10.2
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/net/home/osipovmi/.m2/repository/org/apache/maven/plugins/maven-plugin-plugin/3.10.2/maven-plugin-plugin-3.10.2.jar
[ERROR] urls[1] = file:/net/home/osipovmi/.m2/repository/org/apache/maven/plugin-tools/maven-plugin-tools-api/3.10.2/maven-plugin-tools-api-3.10.2.jar

[michael-o]

As far as I can see with

commit 7c8334ac2466b05ca0cdbeb265dc4b85b0099a2a
Author: Michael Osipov <michaelo@apache.org>
Date:   2023-03-18T23:00:40+01:00

    [DOXIASITETOOLS-294] Replace legacy artifact resolution with Maven Resolver

So Doxia 2.0.0 should be fine with this, but ultimate test will be when this release train is done and I can test more.

[cstamas]

Someone needs to fix maven-plugin-plugin first:

Does this still stands? Or latest one works?

[michael-o]

Someone needs to fix maven-plugin-plugin first:

Does this still stands? Or latest one works?

Both are unrelated. Maven Plugin Plugin remains broken without Maven Compat.

[cstamas]

Fix for m-p-p on the way apache/maven-plugin-tools#280