Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plexus-archiver from 4.2.2 to 4.4.0 #223

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 23, 2022

Bumps plexus-archiver from 4.2.2 to 4.4.0.

Release notes

Sourced from plexus-archiver's releases.

4.4.0

馃殌 New features and improvements

4.3.0

馃殌 New features and improvements

馃摝 Dependency updates

Plexus Archiver 4.2.7

馃殌 New features and improvements

  • Respect order of META-INF/ and META-INF/MANIFEST.MF entries in a JAR file (#189) @鈥媘ichael-o

Plexus Archiver 4.2.6

This release updates commons-compress to 1.21 which contains security fixed for CVE-2021-35517 CVE-2021-35516 CVE-2021-35515 CVE-2021-36090

This version requires Java 8 as minimum (commons-compress 1.21 requires Java 8).

馃殌 New features and improvements

馃摝 Dependency updates

Plexus Archiver 4.2.5

馃殌 New features and improvements

... (truncated)

Commits
  • ac624a7 [maven-release-plugin] prepare release plexus-archiver-4.4.0
  • 4c51190 Bump to 4.4.0
  • 48d3280 Drop legacy plexus API and use only JSR330 components (#220)
  • 337214c [maven-release-plugin] prepare for next development iteration
  • 88d132a [maven-release-plugin] prepare release plexus-archiver-4.3.0
  • e135a2b Bump plexus from 8 to 10
  • e8eecf2 switch build badge from Travis to GH
  • d715d64 Bump release-drafter/release-drafter from 5.19.0 to 5.20.0
  • 50c5fc0 Rename setTime method to setZipEntryTime
  • ee2f99d Bump plexus-io from 3.2.0 to 3.3.1
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.2.2 to 4.4.0.
- [Release notes](https://github.com/codehaus-plexus/plexus-archiver/releases)
- [Changelog](https://github.com/codehaus-plexus/plexus-archiver/blob/master/ReleaseNotes.md)
- [Commits](codehaus-plexus/plexus-archiver@plexus-archiver-4.2.2...plexus-archiver-4.4.0)

---
updated-dependencies:
- dependency-name: org.codehaus.plexus:plexus-archiver
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jun 23, 2022
@slawekjaranowski
Copy link
Member

@jorsol - can you look?

@jorsol
Copy link
Contributor

jorsol commented Sep 12, 2022

@jorsol - can you look?

There are a couple of issues, the first one is that plexus-archiver was updated to drop legacy plexus API codehaus-plexus/plexus-archiver#220 in 4.4.0, the easy fix is to just update the test to do the lookup to the class instead of "ROLE" (which no longer exists).

The second issue is that maven-plugin-testing-harness is using reflection to hack the logger and set a silent log, but from the previous PR the logger was changed to SLF4J instead of plexus logging so this fails:
https://github.com/apache/maven-plugin-testing/blob/7d6518b0d32d820efa15f7b4d022b8524a9b1d1b/maven-plugin-testing-harness/src/main/java/org/apache/maven/plugin/testing/ArtifactStubFactory.java#L305-L313
This is throwing an IllegalArgumentException which is not in the catch (to be ignored), so the fix needs to be done in the testing harness.

The third issue is that the unpack is not overwriting the file when it has to, for this, I need more time to check as I wasn't able to find out why right now.

@slawekjaranowski
Copy link
Member

Ups maven-plugin-testing-harness to fix and release ... 馃槃

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 14, 2022

Superseded by #248.

@dependabot dependabot bot closed this Sep 14, 2022
@dependabot dependabot bot deleted the dependabot/maven/org.codehaus.plexus-plexus-archiver-4.4.0 branch September 14, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
2 participants