Avoid FileInputStream, FileOutputStream, FileReader and FileWriter #183
Conversation
jorsol
force-pushed
the
182-avoidfilestream
branch
from
135f3c3
to
263fbc8
Compare
|
well the issue has been fixed in the jdk in 2017. So I don't understand why is it still a problem? |
The issue has been fixed in jdk 10, there are a lot of jdk 8 projects out there, also this aligns with codehaus-plexus/plexus-utils#111 using NIO to allow better offloading / performance. |
|
Can the JBS issue be provided? |
Where should I open it? |
You said: The issue has been fixed in jdk 10, So there must be already JBS issue for that. |
|
Ok, sorry for the misunderstanding, the JBS is https://bugs.openjdk.java.net/browse/JDK-8080225 |
|
Thanks, then this PR makes sense. @olamy WDYT? |
src/main/java/org/codehaus/plexus/archiver/bzip2/PlexusIoBzip2ResourceCollection.java
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/gzip/PlexusIoGzipResourceCollection.java
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/resources/PlexusIoVirtualFileResource.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/xz/PlexusIoXZResourceCollection.java
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/archiver/zip/AnonymousResource.java
Outdated
Show resolved
Hide resolved
|
@michael-o yup makes sense. I only have minor comments. But OMG what a bad name has been used for a class called |
https://pmd.github.io/latest/pmd_rules_java_performance.html#avoidfilestream Signed-off-by: Jorge Solórzano <jorsol@gmail.com>
jorsol
force-pushed
the
182-avoidfilestream
branch
from
263fbc8
to
fcc1776
Compare
Fixes #182