Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPOM-287] - Disable m2e warning for m-remote-resource-p:process #64

Merged
merged 2 commits into from Jan 27, 2022
Merged

[MPOM-287] - Disable m2e warning for m-remote-resource-p:process #64

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9823608
[MPOM-287] - Disable m2e warning for m-remote-resource-p:process
kwin Jan 19, 2022
607c154
[MPOM-287] - Make m2e exclusion conditional by moving it to a profile
kwin Jan 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
26 changes: 26 additions & 0 deletions pom.xml
View file
Open in desktop
Expand Up @@ -299,6 +299,32 @@ under the License.
<artifactId>apache-rat-plugin</artifactId>
<version>0.13</version>
</plugin>
<!-- Disable execution of some plugins in m2e (https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html) -->
<plugin>
<groupId>org.eclipse.m2e</groupId>
<artifactId>lifecycle-mapping</artifactId>
<version>1.0.0</version>
<configuration>
<lifecycleMappingMetadata>
<pluginExecutions>
<pluginExecution>
<!-- no native m2e support yet (https://issues.apache.org/jira/browse/MRRESOURCES-85) -->
<pluginExecutionFilter>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-remote-resources-plugin</artifactId>
<versionRange>[1.7.0,1.8.0)</versionRange>
<goals>
<goal>process</goal>
</goals>
</pluginExecutionFilter>
<action>
<ignore/>
</action>
</pluginExecution>
</pluginExecutions>
</lifecycleMappingMetadata>
</configuration>
</plugin>
Copy link
Member

@ctubbsii ctubbsii Jan 19, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I strongly recommend putting this in a profile activated by the presence of the m2e.version property.
Also, there's no reason to restrict the version. This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of [0,)
Example:

https://github.com/apache/accumulo/blob/main/pom.xml#L1247-L1351

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

putting this in a profile activated by the presence of the m2e.version property.

Thanks for the hint, done in 607c154.

This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of [0,)

I disagree, I enabled it for [0,1.8) because hopefully the not yet released plugin 1.8 will add support. In case there is this section in the pom.xml unconditionally you prevent that potential support from becoming active. In general it is dangerous to disable it for all versions, as you never know which support is added in future versions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure this section can just be deleted when the plugin version is bumped to one where support was added. But, if the metadata is added to do anything other than ignore inside the plugin itself, and the user specifies a newer version than what's in the parent POM here, then I guess you are right.

</plugins>
</pluginManagement>
<plugins>
Expand Down