[MPOM-287] - Disable m2e warning for m-remote-resource-p:process #64
Conversation
pom.xml
Outdated
| <!-- Disable execution of some plugins in m2e (https://www.eclipse.org/m2e/documentation/m2e-execution-not-covered.html) --> | ||
| <plugin> | ||
| <groupId>org.eclipse.m2e</groupId> | ||
| <artifactId>lifecycle-mapping</artifactId> | ||
| <version>1.0.0</version> | ||
| <configuration> | ||
| <lifecycleMappingMetadata> | ||
| <pluginExecutions> | ||
| <pluginExecution> | ||
| <!-- no native m2e support yet (https://issues.apache.org/jira/browse/MRRESOURCES-85) --> | ||
| <pluginExecutionFilter> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-remote-resources-plugin</artifactId> | ||
| <versionRange>[1.7.0,1.8.0)</versionRange> | ||
| <goals> | ||
| <goal>process</goal> | ||
| </goals> | ||
| </pluginExecutionFilter> | ||
| <action> | ||
| <ignore/> | ||
| </action> | ||
| </pluginExecution> | ||
| </pluginExecutions> | ||
| </lifecycleMappingMetadata> | ||
| </configuration> | ||
| </plugin> |
There was a problem hiding this comment.
I strongly recommend putting this in a profile activated by the presence of the m2e.version property.
Also, there's no reason to restrict the version. This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of [0,)
Example:
https://github.com/apache/accumulo/blob/main/pom.xml#L1247-L1351
There was a problem hiding this comment.
putting this in a profile activated by the presence of the m2e.version property.
Thanks for the hint, done in 607c154.
This is useful to suppress no matter what version of the plugin is used. So, you can just specify a versionRange of [0,)
I disagree, I enabled it for [0,1.8) because hopefully the not yet released plugin 1.8 will add support. In case there is this section in the pom.xml unconditionally you prevent that potential support from becoming active. In general it is dangerous to disable it for all versions, as you never know which support is added in future versions.
There was a problem hiding this comment.
I figure this section can just be deleted when the plugin version is bumped to one where support was added. But, if the metadata is added to do anything other than ignore inside the plugin itself, and the user specifies a newer version than what's in the parent POM here, then I guess you are right.
only active in Eclipse Active for m-remote-resources-p up to (excluding) 1.8.0
No description provided.