fix issue-8695:DefaultFuture turn off logging optimization for Channel #8775
Conversation
| Request newRequest = request.copy(); | ||
| newRequest.setData(null); | ||
| return newRequest; | ||
| private static Request getRequestWithoutData(Request request) { |
There was a problem hiding this comment.
This method can be removed. We can use request. copyWithoutData() directly.
| @@ -147,7 +147,7 @@ public static void closeChannel(Channel channel) { | |||
| disconnectResponse.setErrorMessage("Channel " + | |||
| channel + | |||
| " is inactive. Directly return the unFinished request : " + | |||
| future.getRequest()); | |||
| getRequestWithoutData(future.getRequest())); | |||
There was a problem hiding this comment.
Here use logger.isDebugEnabled() to judge is print data also.
|
@horizonzy I have completed the optimization you mentioned. This is my first submission, and I want to know about the submission of the issue. How to determine which branch to merge into? |
Now we use brnach 3.0 as our default branch. And branch master also be maintained, you can pr to master again. |
Codecov Report
@@ Coverage Diff @@
## 3.0 #8775 +/- ##
============================================
+ Coverage 63.72% 63.74% +0.01%
Complexity 314 314
============================================
Files 1149 1149
Lines 48347 48350 +3
Branches 7291 7292 +1
============================================
+ Hits 30810 30819 +9
+ Misses 14158 14156 -2
+ Partials 3379 3375 -4
Continue to review full report at Codecov.
|
I've submitted to the Master branch again. link #8778 |
What is the purpose of the change
fix #8695 on 3.0
Brief changelog
DefaultFuture turn off logging optimization for Channel.