Fix DefaultFuture turn off exception logging optimization for Channel… #8739
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #8739 +/- ##
============================================
- Coverage 63.71% 63.55% -0.16%
+ Complexity 313 312 -1
============================================
Files 1145 1145
Lines 48183 48137 -46
Branches 7255 7220 -35
============================================
- Hits 30698 30593 -105
- Misses 14115 14167 +52
- Partials 3370 3377 +7
Continue to review full report at Codecov.
|
| + " -> " + channel.getRemoteAddress(); | ||
| } | ||
|
|
||
| private Request getRequestWithoutData() { | ||
| private static Request rinseRequestData(Request request) { |
There was a problem hiding this comment.
Here maintain original method name, rinseRequestData sounds like do some operation for request.
| + " -> " + channel.getRemoteAddress(); | ||
| } | ||
|
|
||
| private Request getRequestWithoutData() { | ||
| private static Request rinseRequestData(Request request) { | ||
| Request newRequest = request.copy(); |
There was a problem hiding this comment.
And here we can optimize the logic. Add new method copy without data method in Request, avoid to copy data.
|
@horizonzy I recommitted and found that there were redundant commit records, so "reset head" caused it to close，I have now resubmitted a PR，link：#8775 |
What is the purpose of the change
fix #8695 on 3.0
Brief changelog
DefaultFuture turn off logging optimization for Channel.
Verifying this change