New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dubbo-6720] fix bug same interface unexport and export fail. also support hotload service #6720
Conversation
@owen200008 Hi, thanks for your contribution. Please merge the latest master branch to resolve confilcts. |
@AlbumenJ I have resolve confilcts |
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractProxyProtocol.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/DelegateExporterMap.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-injvm/src/main/java/org/apache/dubbo/rpc/protocol/injvm/InjvmExporter.java
Outdated
Show resolved
Hide resolved
f246906
to
396a94a
Compare
@AlbumenJ finish thanks! |
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractProtocol.java
Outdated
Show resolved
Hide resolved
dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/protocol/AbstractProtocol.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #6720 +/- ##
============================================
+ Coverage 60.99% 61.09% +0.09%
Complexity 490 490
============================================
Files 1090 1091 +1
Lines 43951 43980 +29
Branches 6423 6429 +6
============================================
+ Hits 26810 26871 +61
+ Misses 14156 14124 -32
Partials 2985 2985
Continue to review full report at Codecov.
|
Great! @owen200008 Would you please pick these changes to 3.0? |
What is the purpose of the change
fix bug same interface unexport and export fail.
delegate exportmap and support hotload export
Brief changelog
Follow this checklist to help us incorporate your contribution quickly and easily:
[Dubbo-XXX] Fix UnknownException when host config not exist #XXX
. Each commit in the pull request should have a meaningful subject line and body.mvn clean install -DskipTests=false
&mvn clean test-compile failsafe:integration-test
to make sure unit-test and integration-test pass.