Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_delete_error_exporter #10383

Merged
merged 1 commit into from Jul 29, 2022
Merged

Conversation

owen200008
Copy link
Contributor

dubbo2.7.x fix
#6720
#6720

@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2022

Codecov Report

Merging #10383 (3f5303d) into 3.0 (e3cc859) will decrease coverage by 0.19%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                3.0   #10383      +/-   ##
============================================
- Coverage     65.72%   65.52%   -0.20%     
+ Complexity      319      317       -2     
============================================
  Files          1233     1234       +1     
  Lines         53721    53855     +134     
  Branches       8119     8154      +35     
============================================
- Hits          35309    35290      -19     
- Misses        14564    14684     +120     
- Partials       3848     3881      +33     
Impacted Files Coverage Δ
...apache/dubbo/rpc/protocol/dubbo/DubboExporter.java 100.00% <100.00%> (ø)
...nt/metadata/ServiceInstanceHostPortCustomizer.java 65.78% <0.00%> (-21.06%) ⬇️
.../apache/dubbo/rpc/filter/ProfilerServerFilter.java 62.85% <0.00%> (-20.00%) ⬇️
...dubbo/remoting/exchange/support/DefaultFuture.java 80.17% <0.00%> (-12.07%) ⬇️
...che/dubbo/registry/client/NopServiceDiscovery.java 44.44% <0.00%> (-11.12%) ⬇️
...va/org/apache/dubbo/remoting/TimeoutException.java 22.22% <0.00%> (-11.12%) ⬇️
...dubbo/common/status/support/LoadStatusChecker.java 58.33% <0.00%> (-8.34%) ⬇️
...bo/rpc/protocol/dubbo/DecodeableRpcInvocation.java 70.19% <0.00%> (-6.74%) ⬇️
...ava/org/apache/dubbo/rpc/proxy/InvocationUtil.java 84.84% <0.00%> (-6.07%) ⬇️
...e/dubbo/rpc/protocol/tri/transport/WriteQueue.java 73.80% <0.00%> (-4.77%) ⬇️
... and 42 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@CrazyHZM CrazyHZM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CrazyHZM CrazyHZM merged commit 4195838 into apache:3.0 Jul 29, 2022
@CrazyHZM CrazyHZM added this to the 3.0.11 milestone Jul 29, 2022
@owen200008 owen200008 deleted the fix_delete_error_exporter branch August 24, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants