Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dubbo-6746]fix generic interface metadata publish log error #6746

Merged
merged 2 commits into from Mar 4, 2021

Conversation

owen200008
Copy link
Contributor

@owen200008 owen200008 commented Sep 16, 2020

What is the purpose of the change

fix generic interface metadata publish log error

Brief changelog

fix generic interface metadata publish log error

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@owen200008 owen200008 changed the title fix generic interface metadata publish log error [Dubbo-6764]fix generic interface metadata publish log error Sep 16, 2020
@owen200008 owen200008 changed the title [Dubbo-6764]fix generic interface metadata publish log error [Dubbo-6746]fix generic interface metadata publish log error Sep 16, 2020
@AlbumenJ
Copy link
Member

@owen200008 hi, could you please describe why you create this pr? Would this fix any issues?

@AlbumenJ AlbumenJ added the status/waiting-for-feedback Need reporters to triage label Feb 25, 2021
@owen200008
Copy link
Contributor Author

when use generic and the interface not in the jar the log will be error.

we have project to proxy remote real dubbo service, the peoject use generic interface to proxy, so we find many error log

@owen200008
Copy link
Contributor Author

确实写了比较久了,使用泛型代理远程dubbo服务的时候一个接口会报一次error,就是这个去掉error日志
实际我们是知道interface的

如果有时间其他几个也审核下
#6720
#6766

@owen200008
Copy link
Contributor Author

owen200008 commented Feb 26, 2021

#6535
remote exception support fastjson serialization
如果有更好的方案请支持下

Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chickenlj chickenlj merged commit eef6b45 into apache:master Mar 4, 2021
@chickenlj chickenlj added this to the 2.7.10 milestone Mar 4, 2021
@owen200008 owen200008 deleted the fix_metadata_support_generic branch August 18, 2021 05:40
vio-lin pushed a commit to vio-lin/incubator-dubbo that referenced this pull request Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/waiting-for-feedback Need reporters to triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants