Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BEAM-5748] Upgrade conscrypt to latest version #12965

Merged
merged 1 commit into from Sep 30, 2020

Conversation

justinwhite
Copy link
Contributor

Ran into issues with a logging client that needed a newer version of conscrypt and noticed the hardcoded dependency hadn't been updated in 2 years.

R: @boyuanzz


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Format the pull request title like [BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replace BEAM-XXX with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

Post-Commit Tests Status (on master branch)

Lang SDK Dataflow Flink Samza Spark Twister2
Go Build Status --- Build Status --- Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status
Build Status
Build Status
Build Status
Python Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
--- Build Status ---
XLang Build Status --- Build Status --- Build Status ---

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status --- --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@boyuanzz
Copy link
Contributor

Run Dataflow ValidatesRunner

@boyuanzz
Copy link
Contributor

Run Java examples on Dataflow Java 11

@boyuanzz
Copy link
Contributor

Run Dataflow ValidatesRunner Java 11

@justinwhite justinwhite changed the title Upgrade conscrypt to latest version [BEAM-5748] Upgrade conscrypt to latest version Sep 29, 2020
@boyuanzz boyuanzz merged commit 443cf83 into apache:master Sep 30, 2020
@veblush
Copy link
Contributor

veblush commented Sep 30, 2020

Awesome! I'm about to make the same PR but you did it. Thanks!

FYI, this is required for gRPC ALTS to have better throughput by saving CPU time significantly. Notable PRs

@lukecwik
Copy link
Member

lukecwik commented Oct 1, 2020

In the future, please validate that the linkage checker doesn't bring up any new linkage issues as per https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades

@veblush
Copy link
Contributor

veblush commented Oct 19, 2020

BTW, doesn't the vendored gRPC need a change? code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants