[BEAM-5748] Upgrade Conscrypt to 2.5.1 in GrpcVendoring_1_26_0 #13150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please validate that the linkage checker doesn't bring up any new linkage issues as per https://cwiki.apache.org/confluence/display/BEAM/Dependency+Upgrades? |
veblush
force-pushed
the
conscrypt
branch
2 times, most recently
from
9d81fd4
to
089f0c0
Compare
|
Linkage check is blocked by BEAM-11250. |
|
I could manage to run the test without errors by adding -PskipCheckerFramework option to beam-linkage-check.sh |
boyuanzz
approved these changes
Nov 13, 2020
veblush
force-pushed
the
conscrypt
branch
2 times, most recently
from
88b1d21
to
0718fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #12965, upgrading Conscrypt in the vendored gRPC to 2.5.1 because it's not shaded so having the same version on both sides would be clearer.
R: @justinwhite @lukecwik
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username).[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
Post-Commit Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.