Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java build flakes: "Memory constraints are impeding performance" #20819

Closed
damccorm opened this issue Jun 4, 2022 · 9 comments · Fixed by #24583
Closed

Java build flakes: "Memory constraints are impeding performance" #20819

damccorm opened this issue Jun 4, 2022 · 9 comments · Fixed by #24583

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

Java Wordcount Direct Runner (ubuntu-latest) failed a couple times on me with the following warning/error. It doesn't seem like "impeding performance" should cause the build to fail altogether, so I'm wondering if there's some way we can silence this warning.


> Task :sdks:java:extensions:protobuf:compileJava
warning: Memory constraints are impeding performance;
please increase max heap size.

...
> Task :sdks:java:extensions:protobuf:compileJava
error: warnings
found and -Werror specified
Note: Some input files use or override a deprecated API.
Note: Recompile
with -Xlint:deprecation for details.
Note: Some input files use unchecked or unsafe operations.
Note:
Recompile with -Xlint:unchecked for details.
1 error
1 warning

> Task :sdks:java:extensions:protobuf:compileJava
FAILED
> Task :runners:core-construction-java:compileJava
Note: Some input files use or override a
deprecated API.
Note: Recompile with -Xlint:deprecation for details.
Note: Some input files use unchecked
or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.

FAILURE: Build failed with
an exception.

* What went wrong:
Execution failed for task ':sdks:java:extensions:protobuf:compileJava'.
>
Compilation failed; see the compiler error output for details.

Imported from Jira BEAM-11837. Original Jira may contain additional context.
Reported by: ibzib.

@kennknowles
Copy link
Member

kennknowles commented Jun 15, 2022

I did not find a way, hence filed typetools/checker-framework/issues/5159

@kennknowles
Copy link
Member

The folks at checkerframework are super responsive and their release process seems to take mere minutes, so if I get a review on typetools/checker-framework#5162 we should be able to move past this. Hopefully the increased heap size helps in the meantime.

@Abacn
Copy link
Contributor

Abacn commented Jun 16, 2022

Still happen: https://ci-beam.apache.org/job/beam_PostCommit_Python38_PR/531/consoleText

warning: Memory constraints are impeding performance; please increase max heap size.
warning: Memory constraints are impeding performance; please increase max heap size.
error: warnings found and -Werror specified

@kennknowles
Copy link
Member

:-(

Re-running should help and once it is cached you will be clear of the problem. Otherwise we could split the memory across even fewer threads to allow a very large heap. In truth, it may not slow us down that much. We should primarily rely on caching for build performance.

@apilloud
Copy link
Member

apilloud commented Nov 17, 2022

Still happening: https://ci-beam.apache.org/job/beam_PreCommit_Java_Examples_Dataflow_Commit/21203/console


14:43:26 > Task :sdks:java:io:google-cloud-platform:compileJava
14:43:57 warning: Memory constraints are impeding performance; please increase max heap size.
14:43:59 warning: Memory constraints are impeding performance; please increase max heap size.
14:44:00 error: warnings found and -Werror specified
14:46:20 Note: Some input files use or override a deprecated API.
14:46:20 Note: Recompile with -Xlint:deprecation for details.
14:46:20 Note: Some input files use unchecked or unsafe operations.
14:46:20 Note: Recompile with -Xlint:unchecked for details.
14:46:20 1 error
14:46:20 2 warnings
14:46:20 
14:46:20 > Task :sdks:java:io:google-cloud-platform:compileJava FAILED

@kennknowles
Copy link
Member

Since checkerframework 3.26.0 this is something we can control.

@kennknowles kennknowles removed their assignment Nov 18, 2022
@kennknowles
Copy link
Member

Freeing this up for anyone to take on since I'm doing other things right now. Good first issue since it doesn't require any context or judgment.

@kennknowles kennknowles self-assigned this Nov 18, 2022
@nbali nbali mentioned this issue Nov 18, 2022
2 tasks
@apilloud
Copy link
Member

Still happening: https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/23807/consoleFull

13:32:59 > Task :sdks:java:extensions:kryo:compileJava
13:32:59 warning: Memory constraints are impeding performance; please increase max heap size.
13:33:03 error: warnings found and -Werror specified
13:33:07 > Task :sdks:java:extensions:kryo:compileJava
13:33:07 1 error
13:33:07 1 warning
13:33:07 

@kennknowles
Copy link
Member

#24410 will enable us to fix this

@github-actions github-actions bot added this to the 2.45.0 Release milestone Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants