Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade checkerframework to 3.27.0 #24238

Closed
wants to merge 3 commits into from

Conversation

kennknowles
Copy link
Member

This fixes #21068 which is about lambda annotations and unblocks #20819 which I will probably do in a second PR or second commit after ensuring the upgrade goes smoothly.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions
Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov
Copy link

codecov bot commented Nov 18, 2022

Codecov Report

Merging #24238 (b0185db) into master (1dd2ccd) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24238   +/-   ##
=======================================
  Coverage   73.45%   73.46%           
=======================================
  Files         714      714           
  Lines       96497    96497           
=======================================
+ Hits        70886    70890    +4     
+ Misses      24289    24285    -4     
  Partials     1322     1322           
Flag Coverage Δ
python 83.17% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../python/apache_beam/testing/test_stream_service.py 88.09% <0.00%> (-4.77%) ⬇️
.../python/apache_beam/transforms/periodicsequence.py 97.01% <0.00%> (-1.50%) ⬇️
...che_beam/runners/interactive/interactive_runner.py 90.50% <0.00%> (-1.27%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.54% <0.00%> (+0.24%) ⬆️
...ks/python/apache_beam/runners/worker/data_plane.py 89.26% <0.00%> (+1.69%) ⬆️
.../apache_beam/runners/interactive/dataproc/types.py 96.55% <0.00%> (+3.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennknowles
Copy link
Member Author

I have been unable to reproduce this. Maybe a gradle cache issue?

@kennknowles
Copy link
Member Author

retest this please

@kennknowles
Copy link
Member Author

Run Spotless PreCommit

@kennknowles
Copy link
Member Author

Now including #24239 to see if it impacts this issue.

@kennknowles
Copy link
Member Author

@github-actions
Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @Abacn for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@github-actions
Copy link
Contributor

Reminder, please take a look at this pr: @Abacn

@kennknowles
Copy link
Member Author

Closing this and will be bisecting

@kennknowles kennknowles deleted the checker branch November 28, 2022 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update checkerframework to 3.16+
1 participant