Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress checker framework memory constraint warning #24583

Merged
merged 1 commit into from Dec 12, 2022

Conversation

kennknowles
Copy link
Member

Fixes #20819


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI.

@github-actions github-actions bot added the build label Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @damccorm for label build.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #24583 (c7cd6f4) into master (fb06ef3) will increase coverage by 0.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #24583      +/-   ##
==========================================
+ Coverage   73.36%   73.57%   +0.20%     
==========================================
  Files         719      719              
  Lines       97125    98055     +930     
==========================================
+ Hits        71257    72142     +885     
- Misses      24520    24565      +45     
  Partials     1348     1348              
Flag Coverage Δ
python 83.15% <ø> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...eam/runners/portability/fn_api_runner/execution.py 93.13% <0.00%> (+0.63%) ⬆️
sdks/python/apache_beam/transforms/core.py 94.36% <0.00%> (+1.45%) ⬆️
...on/apache_beam/runners/dataflow/dataflow_runner.py 83.59% <0.00%> (+1.59%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kennknowles
Copy link
Member Author

Run Java_Pulsar_IO_Direct PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java_Pulsar_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Hrmm. Many of the "in progress" builds are successful, while the failed build is not restarting. We may need to do something different to effectively run just appropriate tests on PRs if this is a capacity/quota issue. I mean, we are talking about "I forgot how to count that low" numbers but we've seen issues still.

@kennknowles
Copy link
Member Author

R: @apilloud who has noted this one a few times (just to spread the build system reviews around)

@kennknowles
Copy link
Member Author

I haven't actually seen a memory constraint failure recently, but this should eliminate them totally so they don't recur.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@kennknowles
Copy link
Member Author

Run Java_Pulsar_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Portable_Python PreCommit

@kennknowles
Copy link
Member Author

Run Java_Clickhouse_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Azure_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Amqp_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Cdap_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_ElasticSearch_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Examples_Dataflow PreCommit

@kennknowles
Copy link
Member Author

Run Java_Examples_Dataflow_Java17 PreCommit

@kennknowles
Copy link
Member Author

Run Java_HBase_IO_Direct PreCommit

1 similar comment
@kennknowles
Copy link
Member Author

Run Java_HBase_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Kudu_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Jms_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Parquet_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Redis_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Solr_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_Splunk_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Java_SingleStore_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run SQL_Java17 PreCommit

@kennknowles
Copy link
Member Author

Run Typescript PreCommit

@kennknowles
Copy link
Member Author

Run Java_HCatalog_IO_Direct PreCommit

@kennknowles
Copy link
Member Author

Run Python_PVR_Flink PreCommit

@kennknowles
Copy link
Member Author

Run PythonFormatter PreCommit

@kennknowles
Copy link
Member Author

Run Python PreCommit

@kennknowles kennknowles merged commit 6bbc396 into apache:master Dec 12, 2022
@kennknowles kennknowles deleted the checker-memory branch December 12, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java build flakes: "Memory constraints are impeding performance"
2 participants