New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: arrow csv decimal256 #3711
Feat: arrow csv decimal256 #3711
Conversation
There is still room for improvement in the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thank you.
To support operations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably return an error instead of panicking on overflow, but this looks good to me 👍
This will allow simplifying trait bounds in a number of other places Co-authored-by: Raphael Taylor-Davies <1781103+tustvold@users.noreply.github.com>
now the function return error instead of panic🤓 |
Thank you. This looks good. |
Thank you again |
Benchmark runs are scheduled for baseline = d740510 and contender = 22c1381. 22c1381 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3474
Rationale for this change
arrow-csv only seems to support decimal128
What changes are included in this PR?
now the arrow-csv can support decimal256
Are there any user-facing changes?
nothing