Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arrow-csv: support decimal256 #3474

Closed
0xYUANTI opened this issue Jan 6, 2023 · 4 comments · Fixed by #3711
Closed

arrow-csv: support decimal256 #3474

0xYUANTI opened this issue Jan 6, 2023 · 4 comments · Fixed by #3711
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@0xYUANTI
Copy link

0xYUANTI commented Jan 6, 2023

I noticed that

https://github.com/apache/arrow-rs/blob/master/arrow-csv/src/reader/mod.rs

only seems to support decimal128 (ended up there via an error message from csv2arrow).
Is there a reason for that? If not, would be amazing if someone could implement support.
Decimal256 is pretty important since its the only way to represent bigints (well big-ish ints) in arrow afaict.

@0xYUANTI 0xYUANTI added the enhancement Any new improvement worthy of a entry in the changelog label Jan 6, 2023
@suxiaogang223
Copy link
Contributor

hi, Is this still valid? and I'm happy to contribute to this project. I'd like to try to fix issue. But no worries if a more experienced contributor wants to take over this issue instead 😀

@suxiaogang223
Copy link
Contributor

I took a look at the code and found that these functions only support the i128 type:

It doesn't seem very hard to support i256, I will be submitting a change soon.

@viirya
Copy link
Member

viirya commented Feb 13, 2023

Thank you @LiShiZhensPi. Usually if an issue is not assigned yet and no others have said they will work on it, it should be open for all contributors to work on. Feel free to take it.

@tustvold
Copy link
Contributor

label_issue.py automatically added labels {'arrow'} from #3711

@tustvold tustvold added the arrow Changes to the arrow crate label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants