Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include integration tests in arrow crate #3196

Merged
merged 1 commit into from Nov 26, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 25, 2022

Which issue does this PR close?

re #3118

Rationale for this change

When I published version 27, I got

error: failed to verify package tarball

Caused by:
  failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`

Caused by:
can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.



error: failed to verify package tarball

Caused by:
  failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`

Caused by:
can't find `csv` test at `tests/csv.rs` or `tests/csv/main.rs`. Please specify test.path if you want to use a non-default path.

I had to delete some entries in the Cargo.toml fil.

What changes are included in this PR?

Include tests directory in the list of files to publish as suggested by @tustvold at #3112 (comment)

Testing

You can see the failure by checking out 27.0.0 and running cargo publish --dry-run:

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-rs/arrow$ cargo publish --dry-run
    Updating crates.io index
   Packaging arrow v27.0.0 (/Users/alamb/Software/arrow-rs/arrow)
   Verifying arrow v27.0.0 (/Users/alamb/Software/arrow-rs/arrow)
error: failed to verify package tarball

Caused by:
  failed to parse manifest at `/Users/alamb/Software/arrow-rs/target/package/arrow-27.0.0/Cargo.toml`

Caused by:
  can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.

With this patch:

(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-rs/arrow$ git cherry-pick  a082f96
Auto-merging arrow/Cargo.toml
[detached HEAD 94083a282] Include integration tests in arrow crate
 Date: Fri Nov 25 14:29:08 2022 -0500
 1 file changed, 1 insertion(+)
(arrow_dev) alamb@MacBook-Pro-8:~/Software/arrow-rs/arrow$ cargo publish --dry-run
    Updating crates.io index
....
ow-27.0.0)
    Finished dev [unoptimized + debuginfo] target(s) in 17.93s
   Uploading arrow v27.0.0 (/Users/alamb/Software/arrow-rs/arrow)
warning: aborting upload due to dry run

Are there any user-facing changes?

No

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 25, 2022
@tustvold tustvold merged commit fd08c31 into apache:master Nov 26, 2022
@ursabot
Copy link

ursabot commented Nov 26, 2022

Benchmark runs are scheduled for baseline = ddaab1d and contender = fd08c31. fd08c31 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@alamb alamb added the development-process Related to development process of arrow-rs label Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants