Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dangling csv and ipc tests in arrow/Cargo.toml #3112

Closed
wants to merge 1 commit into from

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 14, 2022

Which issue does this PR close?

re #3045

Rationale for this change

When trying to release arrow 27.0.0 using (cd arrow && cargo release) I got the following errors until I removed these entries:

error: failed to verify package tarball

Caused by:
  failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`

Caused by:
can't find `ipc` test at `tests/ipc.rs` or `tests/ipc/main.rs`. Please specify test.path if you want to use a non-default path.



error: failed to verify package tarball

Caused by:
  failed to parse manifest at `/Users/alamb/Downloads/apache-arrow-rs-27.0.0/arrow/target/package/arrow-27.0.0/Cargo.toml`

Caused by:
can't find `csv` test at `tests/csv.rs` or `tests/csv/main.rs`. Please specify test.path if you want to use a non-default path.

What changes are included in this PR?

Delete offending entries in Cargo.toml

I am not at all sure deleting them is correct but it is what I needed to do to get the package released on crates.io

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 14, 2022
@alamb alamb changed the title Remove dangling tests Remove dangling csv and ipc tests in arrow/Cargo.toml Nov 14, 2022
@tustvold
Copy link
Contributor

I wonder if the issue is the include directive excludes the integration tests?

@alamb
Copy link
Contributor Author

alamb commented Nov 15, 2022

I plan to look at this one later (before the next release) but don't have the time to devote to tracking it down now

@alamb alamb marked this pull request as draft November 16, 2022 18:35
@alamb alamb marked this pull request as draft November 16, 2022 18:35
@alamb alamb marked this pull request as draft November 16, 2022 18:35
@alamb
Copy link
Contributor Author

alamb commented Nov 16, 2022

Marking as a draft until I have this sorted out

@alamb
Copy link
Contributor Author

alamb commented Nov 25, 2022

Drat -- I didn't sort this out in time for the release -- I'll do it while waiting for some of this release to go out

@alamb
Copy link
Contributor Author

alamb commented Nov 25, 2022

New proposal #3196

(basically I did what @tustvold suggested)

@alamb alamb closed this Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants