Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate decimal256 with i256 directly #3025

Merged
merged 4 commits into from Nov 6, 2022
Merged

Validate decimal256 with i256 directly #3025

merged 4 commits into from Nov 6, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Nov 5, 2022

Which issue does this PR close?

Closes #3024.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Nov 5, 2022
tustvold
tustvold reviewed Nov 5, 2022
View reviewed changes
arrow-buffer/src/bigint.rs Outdated
@@ -87,6 +87,15 @@ impl i256 {
}
}

/// Create an integer value from its representation as high and low byte arrays in little-endian.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we just use the from_le_bytes above?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I originally wanted that. But I cannot make from_le_bytes as const fn.

error[E0015]: cannot call non-const fn `Result::<[u8; 16], TryFromSliceError>::unwrap` in constant functions

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#3026

@tustvold tustvold mentioned this pull request Nov 5, 2022
Merged
tustvold
tustvold approved these changes Nov 6, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it 👍

FYI @liukun4515

@tustvold tustvold added the api-change Changes to the arrow API label Nov 6, 2022
@tustvold tustvold merged commit 488eff0 into apache:master Nov 6, 2022
@ursabot
Copy link

ursabot commented Nov 6, 2022

Benchmark runs are scheduled for baseline = 53b7f64 and contender = 488eff0. 488eff0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@viirya
Copy link
Member Author

viirya commented Nov 6, 2022

Thanks @tustvold

@alamb alamb mentioned this pull request Nov 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compare i256 in validate_decimal256_precision
3 participants
@viirya @ursabot @tustvold