Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare i256 in validate_decimal256_precision #3024

Closed
viirya opened this issue Nov 5, 2022 · 1 comment · Fixed by #3025
Closed

Compare i256 in validate_decimal256_precision #3024

viirya opened this issue Nov 5, 2022 · 1 comment · Fixed by #3025
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@viirya
Copy link
Member

viirya commented Nov 5, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

validate_decimal256_precision validates decimal 256 values by comparing little-endian bytes of decimal value with const byte values. As we moved to i256 now, we can compare i256 directly.

Describe the solution you'd like

Describe alternatives you've considered

Additional context
@viirya viirya added the enhancement Any new improvement worthy of a entry in the changelog label Nov 5, 2022
@viirya viirya mentioned this issue Nov 5, 2022
Merged
@alamb alamb added the arrow Changes to the arrow crate label Nov 11, 2022
@alamb
Copy link
Contributor

alamb commented Nov 11, 2022

label_issue.py automatically added labels {'arrow'} from #3025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Validate decimal256 with i256 directly viirya/arrow-rs
2 participants
@viirya @alamb