Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace from_timestamp by from_timestamp_opt #2894

Merged
merged 1 commit into from Oct 21, 2022
Merged

replace from_timestamp by from_timestamp_opt #2894

merged 1 commit into from Oct 21, 2022

Conversation

waitingkuo
Copy link
Contributor

Which issue does this PR close?

Closes #2892

Rationale for this change

from_timestamp in chrono will be deprecated in 0.4.23

What changes are included in this PR?

Are there any user-facing changes?

@waitingkuo
Copy link
Contributor Author

waitingkuo commented Oct 18, 2022 •
edited

cc @avantgardnerio @liukun4515

@github-actions github-actions bot added the arrow Changes to the arrow crate label Oct 18, 2022
avantgardnerio
avantgardnerio approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@avantgardnerio avantgardnerio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work staying ahead of chrono changes!

BTW when 0.4.23 is out, we can remove all our custom add_months code.

tustvold
tustvold approved these changes Oct 20, 2022
View reviewed changes
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I think it would be good to document the circumstances these methods return None as it wasn't immediately obvious to me

@tustvold tustvold added the api-change Changes to the arrow API label Oct 20, 2022
@tustvold tustvold merged commit 5de555e into apache:master Oct 21, 2022
@waitingkuo waitingkuo mentioned this pull request Oct 24, 2022
Merged
@alamb alamb mentioned this pull request Oct 28, 2022
Closed
@alamb alamb changed the title replace from_timestamp by from_timestamp_opt replace from_timestamp by from_timestamp_opt Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tustvold tustvold tustvold approved these changes

@avantgardnerio avantgardnerio avantgardnerio approved these changes

Assignees
No one assigned
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace from_timestamp by from_timestamp_opt
3 participants
@waitingkuo @tustvold @avantgardnerio