Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace from_timestamp by from_timestamp_opt #2892

Closed
Tracked by #3148
waitingkuo opened this issue Oct 18, 2022 · 1 comment · Fixed by #2894
Closed
Tracked by #3148

replace from_timestamp by from_timestamp_opt #2892

waitingkuo opened this issue Oct 18, 2022 · 1 comment · Fixed by #2894
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@waitingkuo
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

from_timestamp will be deprecated since chrono 0.4.23
https://github.com/chronotope/chrono/blob/main/src/naive/datetime/mod.rs#L117

Describe the solution you'd like

use from_timestamp_opt instead

Describe alternatives you've considered

Additional context
@waitingkuo waitingkuo added the enhancement Any new improvement worthy of a entry in the changelog label Oct 18, 2022
This was referenced Oct 18, 2022
Closed
Closed
Merged
@alamb alamb added the arrow Changes to the arrow crate label Oct 28, 2022
@alamb
Copy link
Contributor

alamb commented Oct 28, 2022

label_issue.py automatically added labels {'arrow'} from #2894

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

replace from_timestamp by from_timestamp_opt waitingkuo/arrow-rs
2 participants
@alamb @waitingkuo