Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Issue 2721 : binary function should not panic but return error w… #2750

Merged
merged 1 commit into from Sep 19, 2022

Conversation

aksharau
Copy link
Contributor

…hen array lengths are unequal

Which issue does this PR close?

Closes #2721.

Rationale for this change

What changes are included in this PR?

The binary and binary_opt do not panic when the input arrays have unequal length.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Sep 16, 2022
@andygrove
Copy link
Member

Thanks for the contribution @aksharau! This looks great.

CI is failing due to an internal error in the Rust compiler 😞

error: internal compiler error: no errors encountered even though `delay_span_bug` issued

@HaoYang670
Copy link
Contributor

Re-trigger the cargo doc as the failure has been fixed

Copy link
Contributor

@HaoYang670 HaoYang670 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @aksharau !

@HaoYang670 HaoYang670 merged commit 3bf6eb9 into apache:master Sep 19, 2022
@ursabot
Copy link

ursabot commented Sep 19, 2022

Benchmark runs are scheduled for baseline = 5e83ef9 and contender = 3bf6eb9. 3bf6eb9 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The binary function should not panic on unequaled array length.
4 participants