Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use total_cmp for floating value ordering and remove nan_ordering feature flag #2614

Merged
merged 1 commit into from Aug 30, 2022
Merged

Use total_cmp for floating value ordering and remove nan_ordering feature flag #2614

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/arrow.yml
View file
Open in desktop
Expand Up @@ -54,9 +54,6 @@ jobs:
- name: Test --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
run: |
cargo test -p arrow --features=force_validate,prettyprint,ipc_compression,ffi,dyn_cmp_dict
- name: Test --features=nan_ordering
run: |
cargo test -p arrow --features "nan_ordering"
- name: Run examples
run: |
# Test arrow examples
Expand Down
2 changes: 0 additions & 2 deletions arrow/Cargo.toml
View file
Open in desktop
Expand Up @@ -87,8 +87,6 @@ pyarrow = ["pyo3", "ffi"]
force_validate = []
# Enable ffi support
ffi = []
# Enable NaN-ordering behavior on comparison kernels
nan_ordering = []
# Enable dyn-comparison of dictionary arrays with other arrays
# Note: this does not impact comparison against scalars
dyn_cmp_dict = []
Expand Down