Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use total_cmp for floating value ordering and remove nan_ordering feature flag #2614

Merged
merged 1 commit into from Aug 30, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented Aug 30, 2022

Which issue does this PR close?

Closes #2613.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Aug 30, 2022
@tustvold tustvold added the api-change Changes to the arrow API label Aug 30, 2022
@tustvold
Copy link
Contributor

Could you perhaps run the benchmarks just to see what performance impact this has?

@viirya
Copy link
Member Author

viirya commented Aug 30, 2022

Sure. I'll run the benchmark.

@viirya
Copy link
Member Author

viirya commented Aug 30, 2022

Ran the comparison benchmarks. No performance difference shown.

@tustvold
Copy link
Contributor

No performance difference shown.

Even when the nan_ordering feature is enabled?

@viirya
Copy link
Member Author

viirya commented Aug 30, 2022

Even when the nan_ordering feature is enabled?

Yes.

@tustvold tustvold merged commit 9f4d56d into apache:master Aug 30, 2022
@ursabot
Copy link

ursabot commented Aug 30, 2022

Benchmark runs are scheduled for baseline = 62eeaa5 and contender = 9f4d56d. 9f4d56d is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@viirya
Copy link
Member Author

viirya commented Aug 30, 2022

Thanks @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Changes to the arrow API arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use total_cmp for floating value ordering and remove nan_ordering feature flag
3 participants