Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skip_records in complex_object_array can skip cross row groups #2332

Merged
merged 2 commits into from Aug 6, 2022
Merged

Make skip_records in complex_object_array can skip cross row groups #2332

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36a07b1
Make skip_records in complex_object_array can skip cross row groups
Ted-Jiang Aug 4, 2022
84259a1
Update parquet/src/arrow/array_reader/complex_object_array.rs
Ted-Jiang Aug 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 17 additions & 11 deletions parquet/src/arrow/array_reader/complex_object_array.rs
View file
Open in desktop
Expand Up @@ -197,19 +197,25 @@ where
}

fn skip_records(&mut self, num_records: usize) -> Result<usize> {
match self.column_reader.as_mut() {
Some(reader) => reader.skip_records(num_records),
None => {
if self.next_column_reader()? {
self.column_reader
.as_mut()
.unwrap()
.skip_records(num_records)
} else {
Ok(0)
}
let mut num_read = 0;
while (self.column_reader.is_some() || self.next_column_reader()?)
&& num_read < num_records
{
let remain_to_skip = num_records - num_read;
let skip = self
.column_reader
.as_mut()
.unwrap()
.skip_records(remain_to_skip)
.unwrap();
Ted-Jiang marked this conversation as resolved.
Show resolved Hide resolved
num_read += skip;
// skip < remain_to_skip means end of row group
// self.next_column_reader() == false means end of file
if skip < remain_to_skip && !self.next_column_reader()? {
break;
}
}
Ok(num_read)
}

fn get_def_levels(&self) -> Option<&[i16]> {
Expand Down