Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make skip_records in complex_object_array can skip cross row groups #2332

Merged
merged 2 commits into from Aug 6, 2022

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

Closes #2331 #2316.

Rationale for this change

doing fuzz test for reading FIXED_LEN_BYTE_ARRAY
Facing one row group one page with 20 rows, but need skip 60 rows.
For now, this case returns 20 as skip_record cause below assert fail.

if skipped != front.row_count {
return Some(Err(general_err!(
"failed to skip rows, expected {}, got {}",
front.row_count,
skipped
)
.into()));
}
continue;
}

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the parquet Changes to the parquet crate label Aug 5, 2022
@alamb alamb requested a review from tustvold August 5, 2022 11:35
Co-authored-by: Kun Liu <liukun@apache.org>
Copy link
Contributor

@liukun4515 liukun4515 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Ted-Jiang
Copy link
Member Author

@tustvold PTAL have tested in fuzz test.

@tustvold tustvold merged commit 38764c2 into apache:master Aug 6, 2022
@ursabot
Copy link

ursabot commented Aug 6, 2022

Benchmark runs are scheduled for baseline = 30c94db and contender = 38764c2. 38764c2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow skip_records in GenericColumnReader to skip across row groups
4 participants