Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move FixedSizeList to array_fixed_size_list.rs #2250

Merged
merged 1 commit into from Aug 1, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None. This is a subtask of #2217.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

Signed-off-by: remzi <13716567376yh@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #2250 (d98b2d4) into master (f41fb1c) will decrease coverage by 0.02%.
The diff coverage is 92.91%.

@@            Coverage Diff             @@
##           master    #2250      +/-   ##
==========================================
- Coverage   82.30%   82.27%   -0.03%     
==========================================
  Files         241      244       +3     
  Lines       62437    62443       +6     
==========================================
- Hits        51389    51378      -11     
- Misses      11048    11065      +17     
Impacted Files Coverage Δ
arrow/src/array/array_list.rs 95.83% <ø> (+0.72%) ⬆️
arrow/src/array/mod.rs 100.00% <ø> (ø)
arrow/src/array/array_fixed_size_list.rs 92.91% <92.91%> (ø)
...rquet/src/arrow/record_reader/definition_levels.rs 84.81% <0.00%> (-2.54%) ⬇️
arrow/src/array/builder/boolean_buffer_builder.rs 97.05% <0.00%> (-0.99%) ⬇️
parquet/src/encodings/rle.rs 91.91% <0.00%> (-0.52%) ⬇️
arrow/src/datatypes/datatype.rs 62.30% <0.00%> (-0.40%) ⬇️
parquet/src/util/bit_util.rs 93.92% <0.00%> (-0.28%) ⬇️
arrow/src/array/builder/decimal_builder.rs 86.09% <0.00%> (-0.19%) ⬇️
parquet/src/encodings/encoding/dict_encoder.rs 91.22% <0.00%> (-0.16%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@tustvold tustvold merged commit b879977 into apache:master Aug 1, 2022
@ursabot
Copy link

ursabot commented Aug 1, 2022

Benchmark runs are scheduled for baseline = 3032a52 and contender = b879977. b879977 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaoYang670 HaoYang670 deleted the move_fixed_list branch August 1, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants