Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split the FixedSizeBinaryArray and FixedSizeListArray from array_binary.rs and array_list.rs #2217

Closed
2 tasks done
HaoYang670 opened this issue Jul 29, 2022 · 0 comments
Closed
2 tasks done
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

HaoYang670 commented Jul 29, 2022

Describe the solution you'd like
I want to move the FixedSizeBinaryArray to a new file array_fixed_size_binary.rs because

  1. FixedSizeBinaryArray and BinaryArray are 2 different types.
  2. array_binary.rs has been a large file, which is different to read.
  3. We want more precise code coverage report.
  4. More friendly with IDE when showing multiple views at the same time.

Same reasons for FixedSizeListArray.

Checklist:

Describe alternatives you've considered
We could not do this.

Additional context

@HaoYang670 HaoYang670 added the enhancement Any new improvement worthy of a entry in the changelog label Jul 29, 2022
@alamb alamb added the arrow Changes to the arrow crate label Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants