Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DecimalBuilder should use FixedSizeBinaryBuilder #2092

Merged

Conversation

HaoYang670
Copy link
Contributor

@HaoYang670 HaoYang670 commented Jul 18, 2022

Which issue does this PR close?

Closes #2026.

Rationale for this change

What changes are included in this PR?

  1. Let the DecimalBuilder use FixedSizeBinaryBuilder
  2. Deprecate the method from_fixed_size_list_array

Are there any user-facing changes?

Yes

Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label Jul 18, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2092 (d20628a) into master (c585544) will decrease coverage by 0.00%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##           master    #2092      +/-   ##
==========================================
- Coverage   83.73%   83.73%   -0.01%     
==========================================
  Files         224      225       +1     
  Lines       59391    59362      -29     
==========================================
- Hits        49733    49704      -29     
  Misses       9658     9658              
Impacted Files Coverage Δ
arrow/src/array/array_decimal.rs 90.59% <ø> (ø)
arrow/src/array/builder/decimal_builder.rs 83.03% <90.90%> (-2.34%) ⬇️
parquet/src/data_type.rs 74.25% <0.00%> (-1.49%) ⬇️
parquet/src/file/statistics.rs 91.49% <0.00%> (-1.07%) ⬇️
parquet/src/column/writer.rs
parquet/src/column/writer/encoder.rs 88.46% <0.00%> (ø)
parquet/src/column/writer/mod.rs 92.53% <0.00%> (ø)
parquet/src/encodings/encoding.rs 93.62% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c585544...d20628a. Read the comment docs.

@tustvold tustvold merged commit 53e9388 into apache:master Jul 18, 2022
@ursabot
Copy link

ursabot commented Jul 18, 2022

Benchmark runs are scheduled for baseline = 02371d2 and contender = 53e9388. 53e9388 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@HaoYang670
Copy link
Contributor Author

Thank you @tustvold !

@HaoYang670 HaoYang670 deleted the decimal_builder_uses_fixed_binary_builder branch July 18, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The DecimalArrayBuilder should use FixedSizedBinaryBuilder
4 participants