Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The DecimalArrayBuilder should use FixedSizedBinaryBuilder #2026

Closed
2 tasks done
HaoYang670 opened this issue Jul 8, 2022 · 0 comments · Fixed by #2092
Closed
2 tasks done

The DecimalArrayBuilder should use FixedSizedBinaryBuilder #2026

HaoYang670 opened this issue Jul 8, 2022 · 0 comments · Fixed by #2092
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog

Comments

@HaoYang670
Copy link
Contributor

HaoYang670 commented Jul 8, 2022

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Currently, the decimal array builder use FixedSizedListBuilder. This is not a good solution because:

  1. DecimalArray::from_fixed_size_list_array is a “dangerous” function: The null buffer of the child data is dropped.
  2. More space is occupied: To build a fixed size list array, we have to create another child array data. But what we need is just the value buffer

Describe the solution you'd like

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants